Calculate the default nbOrItemsPerRow from the screen size #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
commented
Mar 17, 2023
| width: number, | ||
| height: number | ||
| width = 2, | ||
| height = 2 |
There was a problem hiding this comment.
It was great having this on the extension side, but since we rely so much on screen size now. I think it'll be best to move this back on the webview side.
|
See #2585 (comment) I don't think this is worth it. Happy to re-open and continue if anyone else thinks otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2585
Screen.Recording.2023-03-17.at.2.30.43.PM.mov
Screen.Recording.2023-03-17.at.2.31.08.PM.mov
Both recorder after reseting the state